OSDN Git Service

ipmi: do not take/drop iothread lock
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 25 Jan 2016 12:46:43 +0000 (13:46 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 9 Feb 2016 14:46:54 +0000 (15:46 +0100)
This is not necessary and actually causes a hang; it was probably copied
and pasted from KVM code, that is one of the very few places that run
outside iothread lock.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/ipmi/ipmi.c

index dfab272..6adec1e 100644 (file)
@@ -51,9 +51,7 @@ static int ipmi_do_hw_op(IPMIInterface *s, enum ipmi_op op, int checkonly)
         if (checkonly) {
             return 0;
         }
-        qemu_mutex_lock_iothread();
         qmp_inject_nmi(NULL);
-        qemu_mutex_unlock_iothread();
         return 0;
 
     case IPMI_POWERCYCLE_CHASSIS: