OSDN Git Service

ice: suppress checked_return error
authorBruce Allan <bruce.w.allan@intel.com>
Thu, 12 Dec 2019 11:13:04 +0000 (03:13 -0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Sat, 4 Jan 2020 00:08:33 +0000 (16:08 -0800)
Coverity reports an error that is not really an error; suppress it.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_dcb_lib.c

index d3d3ec2..0664e5b 100644 (file)
@@ -396,6 +396,12 @@ dcb_error:
        prev_cfg->etscfg.tcbwtable[0] = ICE_TC_MAX_BW;
        prev_cfg->etscfg.tsatable[0] = ICE_IEEE_TSA_ETS;
        memcpy(&prev_cfg->etsrec, &prev_cfg->etscfg, sizeof(prev_cfg->etsrec));
+       /* Coverity warns the return code of ice_pf_dcb_cfg() is not checked
+        * here as is done for other calls to that function. That check is
+        * not necessary since this is in this function's error cleanup path.
+        * Suppress the Coverity warning with the following comment...
+        */
+       /* coverity[check_return] */
        ice_pf_dcb_cfg(pf, prev_cfg, false);
        kfree(prev_cfg);
 }