OSDN Git Service

net: dsa: lan9303: Drop port range check
authorEgil Hjelmeland <privat@egil-hjelmeland.no>
Mon, 6 Nov 2017 14:19:49 +0000 (15:19 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 8 Nov 2017 04:35:01 +0000 (13:35 +0900)
Now that ds->num_ports is 3, there is no need to check range of "port"
parameter.

Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/lan9303-core.c

index 70ecd18..320651a 100644 (file)
@@ -1057,17 +1057,7 @@ static int lan9303_port_enable(struct dsa_switch *ds, int port,
 {
        struct lan9303 *chip = ds->priv;
 
-       /* enable internal packet processing */
-       switch (port) {
-       case 1:
-       case 2:
-               return lan9303_enable_processing_port(chip, port);
-       default:
-               dev_dbg(chip->dev,
-                       "Error: request to power up invalid port %d\n", port);
-       }
-
-       return -ENODEV;
+       return lan9303_enable_processing_port(chip, port);
 }
 
 static void lan9303_port_disable(struct dsa_switch *ds, int port,
@@ -1075,18 +1065,9 @@ static void lan9303_port_disable(struct dsa_switch *ds, int port,
 {
        struct lan9303 *chip = ds->priv;
 
-       /* disable internal packet processing */
-       switch (port) {
-       case 1:
-       case 2:
-               lan9303_disable_processing_port(chip, port);
-               lan9303_phy_write(ds, chip->phy_addr_sel_strap + port,
-                                 MII_BMCR, BMCR_PDOWN);
-               break;
-       default:
-               dev_dbg(chip->dev,
-                       "Error: request to power down invalid port %d\n", port);
-       }
+       lan9303_disable_processing_port(chip, port);
+       lan9303_phy_write(ds, chip->phy_addr_sel_strap + port,
+                         MII_BMCR, BMCR_PDOWN);
 }
 
 static int lan9303_port_bridge_join(struct dsa_switch *ds, int port,