OSDN Git Service

Fix flaky AlarmTest.test_set_long_*
authorMarie Janssen <jamuraa@google.com>
Tue, 29 Dec 2015 23:34:55 +0000 (15:34 -0800)
committerMarie Janssen <jamuraa@google.com>
Wed, 30 Dec 2015 00:01:17 +0000 (16:01 -0800)
The "long" tests need some leeway for the timer to be checked because
sometimes it takes ~1-2ms to check timers for wakelock scheduling.

Bug: 26140385
Change-Id: I362166f1d93a811f3933776294775b594226ab30

osi/test/alarm_test.cpp

index 1b4895c..88beaf5 100644 (file)
@@ -109,7 +109,7 @@ TEST_F(AlarmTest, test_set_short) {
 
 TEST_F(AlarmTest, test_set_long) {
   alarm_t *alarm = alarm_new();
-  alarm_set(alarm, TIMER_INTERVAL_FOR_WAKELOCK_IN_MS, cb, NULL);
+  alarm_set(alarm, TIMER_INTERVAL_FOR_WAKELOCK_IN_MS + EPSILON_MS, cb, NULL);
 
   EXPECT_EQ(cb_counter, 0);
   EXPECT_FALSE(WakeLockHeld());
@@ -180,8 +180,8 @@ TEST_F(AlarmTest, test_set_long_long) {
     alarm_new()
   };
 
-  alarm_set(alarm[0], TIMER_INTERVAL_FOR_WAKELOCK_IN_MS, cb, NULL);
-  alarm_set(alarm[1], 2 * TIMER_INTERVAL_FOR_WAKELOCK_IN_MS + EPSILON_MS, cb, NULL);
+  alarm_set(alarm[0], TIMER_INTERVAL_FOR_WAKELOCK_IN_MS + EPSILON_MS, cb, NULL);
+  alarm_set(alarm[1], 2 * (TIMER_INTERVAL_FOR_WAKELOCK_IN_MS + EPSILON_MS), cb, NULL);
 
   EXPECT_EQ(cb_counter, 0);
   EXPECT_FALSE(WakeLockHeld());