OSDN Git Service

qga: Replace an unreachable error by abort()
authorMarkus Armbruster <armbru@redhat.com>
Fri, 13 Nov 2020 08:26:23 +0000 (09:26 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 10 Dec 2020 16:16:44 +0000 (17:16 +0100)
check_suspend_mode()'s error message

    Parameter 'mode' expects GuestSuspendMode

makes no sense to users: GuestSuspendMode is a C enum.  Fortunately,
it is unreachable.  Replace it by abort().

Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20201113082626.2725812-8-armbru@redhat.com>

qga/commands-win32.c

index 300b87c..87dc43e 100644 (file)
@@ -1441,8 +1441,7 @@ static void check_suspend_mode(GuestSuspendMode mode, Error **errp)
         }
         break;
     default:
-        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "mode",
-                   "GuestSuspendMode");
+        abort();
     }
 }