OSDN Git Service

rtc: rv3032: let the core handle the alarm resolution
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 7 Nov 2021 22:54:48 +0000 (23:54 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 9 Nov 2021 23:45:57 +0000 (00:45 +0100)
Let the RTC core know the resolution of the alarm is a minute.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20211107225458.111068-3-alexandre.belloni@bootlin.com
drivers/rtc/rtc-rv3032.c

index a3c7317..c3bee30 100644 (file)
@@ -311,14 +311,6 @@ static int rv3032_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
        u8 ctrl = 0;
        int ret;
 
-       /* The alarm has no seconds, round up to nearest minute */
-       if (alrm->time.tm_sec) {
-               time64_t alarm_time = rtc_tm_to_time64(&alrm->time);
-
-               alarm_time += 60 - alrm->time.tm_sec;
-               rtc_time64_to_tm(alarm_time, &alrm->time);
-       }
-
        ret = regmap_update_bits(rv3032->regmap, RV3032_CTRL2,
                                 RV3032_CTRL2_AIE | RV3032_CTRL2_UIE, 0);
        if (ret)
@@ -958,6 +950,7 @@ static int rv3032_probe(struct i2c_client *client)
        rv3032_trickle_charger_setup(&client->dev, rv3032);
 
        set_bit(RTC_FEATURE_BACKUP_SWITCH_MODE, rv3032->rtc->features);
+       set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rv3032->rtc->features);
 
        rv3032->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
        rv3032->rtc->range_max = RTC_TIMESTAMP_END_2099;