OSDN Git Service

C++: Make Source::revision unsigned instead of int.
authorChristian Kamm <christian.d.kamm@nokia.com>
Mon, 15 Aug 2011 11:10:08 +0000 (13:10 +0200)
committerChristian Kamm <christian.d.kamm@nokia.com>
Tue, 16 Aug 2011 06:02:50 +0000 (08:02 +0200)
All places that use it deal with unsigned revisions:
* SemanticInfo::revision
* Document::revision
* CPPEditorWidget::editorRevision

Even though QTextDocument::revision is int.

Change-Id: I2b3a94056d15fd02539d14c7cec35511abed57b5
Reviewed-on: http://codereview.qt.nokia.com/2954
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
src/plugins/cppeditor/cppeditor.cpp
src/plugins/cppeditor/cppeditor.h

index 420d64f..bc07e4f 100644 (file)
@@ -2159,7 +2159,7 @@ SemanticInfo SemanticHighlighter::semanticInfo(const Source &source)
 
     m_mutex.lock();
     if (! source.force
-            && m_lastSemanticInfo.revision == (unsigned)source.revision
+            && m_lastSemanticInfo.revision == source.revision
             && m_lastSemanticInfo.doc
             && m_lastSemanticInfo.doc->translationUnit()->ast()
             && m_lastSemanticInfo.doc->fileName() == source.fileName) {
index 6b7cc87..a90026f 100644 (file)
@@ -92,7 +92,7 @@ public:
         QString code;
         int line;
         int column;
-        int revision;
+        unsigned revision;
         bool force;
 
         Source()
@@ -103,7 +103,7 @@ public:
                const QString &fileName,
                const QString &code,
                int line, int column,
-               int revision)
+               unsigned revision)
             : snapshot(snapshot), fileName(fileName),
               code(code), line(line), column(column),
               revision(revision), force(false)