OSDN Git Service

serial: sh-sci: Drop superfluous assignment in sci_request_dma()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 20 Jul 2018 12:18:26 +0000 (14:18 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 21 Jul 2018 06:40:51 +0000 (08:40 +0200)
No later code uses the assigned value, so it can be dropped.

Reported-by: Simon Horman <horms@verge.net.au>
Fixes: 2c4ee23530ffc022 ("serial: sh-sci: Postpone DMA release when falling back to PIO")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c

index f8e53ac..6ff6f2b 100644 (file)
@@ -1574,7 +1574,6 @@ static void sci_request_dma(struct uart_port *port)
                if (dma_mapping_error(chan->device->dev, s->tx_dma_addr)) {
                        dev_warn(port->dev, "Failed mapping Tx DMA descriptor\n");
                        dma_release_channel(chan);
-                       chan = NULL;
                } else {
                        dev_dbg(port->dev, "%s: mapped %lu@%p to %pad\n",
                                __func__, UART_XMIT_SIZE,