OSDN Git Service

net/mlx5: E-Switch, Fix the warning on vport index out of range
authorBodong Wang <bodong@mellanox.com>
Mon, 18 Feb 2019 04:23:16 +0000 (22:23 -0600)
committerSaeed Mahameed <saeedm@mellanox.com>
Tue, 19 Feb 2019 22:15:04 +0000 (14:15 -0800)
When eswitch gets vport data structure, the index should not be out
of the range of the vport array. Driver mistakenly used vport number
to check the range.

Fixes: 22b8ddc86bf4 ("net/mlx5: E-Switch, Assign a different position for uplink rep and vport")
Signed-off-by: Bodong Wang <bodong@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c

index e18af31..d4f6859 100644 (file)
@@ -87,7 +87,7 @@ static struct mlx5_vport *mlx5_eswitch_get_vport(struct mlx5_eswitch *esw,
 {
        u16 idx = mlx5_eswitch_vport_num_to_index(esw, vport_num);
 
-       WARN_ON(vport_num > esw->total_vports - 1);
+       WARN_ON(idx > esw->total_vports - 1);
        return &esw->vports[idx];
 }