OSDN Git Service

ASoC: tegra20_ac97: Fix missing error code in tegra20_ac97_platform_probe()
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Fri, 1 Jul 2022 07:28:50 +0000 (15:28 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 4 Jul 2022 11:44:21 +0000 (12:44 +0100)
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.

This was found by coccicheck:

sound/soc/tegra/tegra20_ac97.c:357 tegra20_ac97_platform_probe() warn: missing error code 'ret'.

Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/20220701072850.62408-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/tegra/tegra20_ac97.c

index e17375c..87facfb 100644 (file)
@@ -354,6 +354,7 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev)
                }
        } else {
                dev_err(&pdev->dev, "no codec-reset GPIO supplied\n");
+               ret = -EINVAL;
                goto err_clk_put;
        }
 
@@ -361,6 +362,7 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev)
                                            "nvidia,codec-sync-gpio", 0);
        if (!gpio_is_valid(ac97->sync_gpio)) {
                dev_err(&pdev->dev, "no codec-sync GPIO supplied\n");
+               ret = -EINVAL;
                goto err_clk_put;
        }