OSDN Git Service

drm/i915: Don't use the second dbuf slice on icl
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 30 Jan 2019 15:51:10 +0000 (17:51 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 31 Jan 2019 07:00:08 +0000 (09:00 +0200)
The code managing the dbuf slices is borked and needs some
real work to fix. In the meantime let's just stop using the
second slice.

v2: Drop the change to intel_enabled_dbuf_slices_num() (Mahesh)

Cc: Mahesh Kumar <mahesh1.sh.kumar@gmail.com>
Reviewed-by: Imre Deak <imre.deak@intel.com> #v1
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190130155110.12918-1-ville.syrjala@linux.intel.com
Reviewed-by: Mahesh Kumar <mahesh1.sh.kumar@gmail.com>
drivers/gpu/drm/i915/intel_pm.c

index 53b7061..ed97862 100644 (file)
@@ -3822,8 +3822,13 @@ static u16 intel_get_ddb_size(struct drm_i915_private *dev_priv,
 
        /*
         * 12GB/s is maximum BW supported by single DBuf slice.
+        *
+        * FIXME dbuf slice code is broken:
+        * - must wait for planes to stop using the slice before powering it off
+        * - plane straddling both slices is illegal in multi-pipe scenarios
+        * - should validate we stay within the hw bandwidth limits
         */
-       if (num_active > 1 || total_data_bw >= GBps(12)) {
+       if (0 && (num_active > 1 || total_data_bw >= GBps(12))) {
                ddb->enabled_slices = 2;
        } else {
                ddb->enabled_slices = 1;