OSDN Git Service

iommu/mediatek: Remove the power status checking in tlb flush all
authorYong Wu <yong.wu@mediatek.com>
Wed, 8 Dec 2021 12:07:42 +0000 (14:07 +0200)
committerJoerg Roedel <jroedel@suse.de>
Fri, 4 Mar 2022 10:04:45 +0000 (11:04 +0100)
To simplify the code, Remove the power status checking in the
tlb_flush_all, remove this:
   if (pm_runtime_get_if_in_use(data->dev) <= 0)
    continue;

The mtk_iommu_tlb_flush_all is called from
a) isr
b) tlb flush range fail case
c) iommu_create_device_direct_mappings

In first two cases, the power and clock are always enabled.
In the third case tlb flush is unnecessary because in a later patch
in the series a full flush from the pm_runtime_resume callback is added.

In addition, writing the tlb control register when the iommu is not resumed
is ok and the write is ignored.

Signed-off-by: Yong Wu <yong.wu@mediatek.com>
[refactor commit log]
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20211208120744.2415-4-dafna.hirschfeld@collabora.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/mtk_iommu.c

index bcf1f5e..7cdf281 100644 (file)
@@ -210,15 +210,10 @@ static struct mtk_iommu_domain *to_mtk_domain(struct iommu_domain *dom)
 
 static void mtk_iommu_tlb_flush_all(struct mtk_iommu_data *data)
 {
-       if (pm_runtime_get_if_in_use(data->dev) <= 0)
-               return;
-
        writel_relaxed(F_INVLD_EN1 | F_INVLD_EN0,
                       data->base + data->plat_data->inv_sel_reg);
        writel_relaxed(F_ALL_INVLD, data->base + REG_MMU_INVALIDATE);
        wmb(); /* Make sure the tlb flush all done */
-
-       pm_runtime_put(data->dev);
 }
 
 static void mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size,