OSDN Git Service

regulator: rk808: Lower log level on optional GPIOs being not available
authorMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 3 Dec 2019 16:47:09 +0000 (17:47 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Feb 2020 07:34:40 +0000 (08:34 +0100)
[ Upstream commit b8a039d37792067c1a380dc710361905724b9b2f ]

RK808 can leverage a couple of GPIOs to tweak the ramp rate during DVS
(Dynamic Voltage Scaling). These GPIOs are entirely optional but a
dev_warn() appeared when cleaning this driver to use a more up-to-date
gpiod API. At least reduce the log level to 'info' as it is totally
fine to not populate these GPIO on a hardware design.

This change is trivial but it is worth not polluting the logs during
bringup phase by having real warnings and errors sorted out
correctly.

Fixes: a13eaf02e2d6 ("regulator: rk808: make better use of the gpiod API")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20191203164709.11127-1-miquel.raynal@bootlin.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/regulator/rk808-regulator.c

index 213b687..92498ac 100644 (file)
@@ -714,7 +714,7 @@ static int rk808_regulator_dt_parse_pdata(struct device *dev,
                }
 
                if (!pdata->dvs_gpio[i]) {
-                       dev_warn(dev, "there is no dvs%d gpio\n", i);
+                       dev_info(dev, "there is no dvs%d gpio\n", i);
                        continue;
                }