OSDN Git Service

Merge "Use null error_msg for pic images"
authorTreehugger Robot <treehugger-gerrit@google.com>
Sat, 11 Feb 2017 04:57:39 +0000 (04:57 +0000)
committerGerrit Code Review <noreply-gerritcodereview@google.com>
Sat, 11 Feb 2017 04:57:40 +0000 (04:57 +0000)
1  2 
runtime/gc/space/image_space.cc

@@@ -802,16 -807,14 +807,18 @@@ class ImageSpaceLoader 
            reinterpret_cast<char*>(map->Begin()) + decompress_offset,
            stored_size,
            map->Size() - decompress_offset);
 -      VLOG(image) << "Decompressing image took " << PrettyDuration(NanoTime() - start);
 +      const uint64_t time = NanoTime() - start;
 +      // Add one 1 ns to prevent possible divide by 0.
 +      VLOG(image) << "Decompressing image took " << PrettyDuration(time) << " ("
 +                  << PrettySize(static_cast<uint64_t>(map->Size()) * MsToNs(1000) / (time + 1))
 +                  << "/s)";
        if (decompressed_size + sizeof(ImageHeader) != image_header.GetImageSize()) {
-         *error_msg = StringPrintf(
-             "Decompressed size does not match expected image size %zu vs %zu",
-             decompressed_size + sizeof(ImageHeader),
-             image_header.GetImageSize());
+         if (error_msg != nullptr) {
+           *error_msg = StringPrintf(
+               "Decompressed size does not match expected image size %zu vs %zu",
+               decompressed_size + sizeof(ImageHeader),
+               image_header.GetImageSize());
+         }
          return nullptr;
        }
      }