OSDN Git Service

staging: rtl8712: rewrite the right hand side of an assignment
authorAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Thu, 26 Feb 2015 09:38:12 +0000 (11:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Feb 2015 23:23:47 +0000 (15:23 -0800)
This patch rewrites the right hand side of an assignment for
expressions of the form:
a = (a <op> b);
to be:
a <op>= b;
where <op> = << | >>.

This issue was detected and resolved using the following
coccinelle script:

@@
identifier i;
expression e;
@@

-i = (i >> e);
+i >>= e;

@@
identifier i;
expression e;
@@

-i = (i << e);
+i <<= e;

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl8712_cmd.c

index 62e53cc..007f0a3 100644 (file)
@@ -95,7 +95,7 @@ static void query_fw_rx_phy_status(struct _adapter *padapter)
                        val32 = r8712_read32(padapter, IOCMD_DATA_REG);
                else /* time out */
                        val32 = 0;
-               val32 = val32 >> 4;
+               val32 >>= 4;
                padapter->recvpriv.fw_rssi =
                         (u8)r8712_signal_scale_mapping(val32);
        }