OSDN Git Service

[media] saa7146: remove return after BUG()
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 24 Sep 2014 19:24:50 +0000 (16:24 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Fri, 26 Sep 2014 09:47:57 +0000 (06:47 -0300)
As reported by smatch:
drivers/media/common/saa7146/saa7146_fops.c:314 fops_mmap() info: ignoring unreachable code.
drivers/media/common/saa7146/saa7146_fops.c:402 fops_read() info: ignoring unreachable code.
drivers/media/common/saa7146/saa7146_fops.c:426 fops_write() info: ignoring unreachable code.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/common/saa7146/saa7146_fops.c

index 6c47f3f..b7d6393 100644 (file)
@@ -311,7 +311,6 @@ static int fops_mmap(struct file *file, struct vm_area_struct * vma)
                }
        default:
                BUG();
-               return 0;
        }
 
        if (mutex_lock_interruptible(vdev->lock))
@@ -399,7 +398,6 @@ static ssize_t fops_read(struct file *file, char __user *data, size_t count, lof
                return -EINVAL;
        default:
                BUG();
-               return 0;
        }
 }
 
@@ -423,7 +421,6 @@ static ssize_t fops_write(struct file *file, const char __user *data, size_t cou
                return -EINVAL;
        default:
                BUG();
-               return -EINVAL;
        }
 }