OSDN Git Service

dpaa2-eth: Minor refactoring in ethtool stats
authorIoana Radulescu <ruxandra.radulescu@nxp.com>
Mon, 2 Sep 2019 10:23:17 +0000 (13:23 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Sep 2019 22:24:06 +0000 (00:24 +0200)
As we prepare to read more pages from the DPNI stat counters,
reorganize the code a bit to make it easier to extend.

Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c

index 93076fe..1c5b54b 100644 (file)
@@ -188,6 +188,11 @@ static void dpaa2_eth_get_ethtool_stats(struct net_device *net_dev,
        struct dpaa2_eth_priv *priv = netdev_priv(net_dev);
        struct dpaa2_eth_drv_stats *extras;
        struct dpaa2_eth_ch_stats *ch_stats;
+       int dpni_stats_page_size[DPNI_STATISTICS_CNT] = {
+               sizeof(dpni_stats.page_0),
+               sizeof(dpni_stats.page_1),
+               sizeof(dpni_stats.page_2),
+       };
 
        memset(data, 0,
               sizeof(u64) * (DPAA2_ETH_NUM_STATS + DPAA2_ETH_NUM_EXTRA_STATS));
@@ -198,17 +203,8 @@ static void dpaa2_eth_get_ethtool_stats(struct net_device *net_dev,
                                          j, &dpni_stats);
                if (err != 0)
                        netdev_warn(net_dev, "dpni_get_stats(%d) failed\n", j);
-               switch (j) {
-               case 0:
-                       num_cnt = sizeof(dpni_stats.page_0) / sizeof(u64);
-                       break;
-               case 1:
-                       num_cnt = sizeof(dpni_stats.page_1) / sizeof(u64);
-                       break;
-               case 2:
-                       num_cnt = sizeof(dpni_stats.page_2) / sizeof(u64);
-                       break;
-               }
+
+               num_cnt = dpni_stats_page_size[j] / sizeof(u64);
                for (k = 0; k < num_cnt; k++)
                        *(data + i++) = dpni_stats.raw.counter[k];
        }