OSDN Git Service

staging: rtl8192u: Replace symbolic permissions with octal permissions
authorsimran singhal <singhalsimran0@gmail.com>
Thu, 16 Feb 2017 20:36:56 +0000 (02:06 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Mar 2017 08:17:01 +0000 (09:17 +0100)
Octal permissions should be used instead of symbolic ones for easier
reading.

WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.
This warning is detected by checkpatch.pl

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

index 5fdfff0..a791175 100644 (file)
@@ -283,8 +283,7 @@ int __init ieee80211_debug_init(void)
                                " proc directory\n");
                return -EIO;
        }
-       e = proc_create("debug_level", S_IRUGO | S_IWUSR,
-                             ieee80211_proc, &fops);
+       e = proc_create("debug_level", 0644, ieee80211_proc, &fops);
        if (!e) {
                remove_proc_entry(DRV_NAME, init_net.proc_net);
                ieee80211_proc = NULL;