OSDN Git Service

drm/rockchip: Avoid uninitialized use of endpoint id in LVDS
authorPaul Kocialkowski <paul.kocialkowski@bootlin.com>
Tue, 10 Nov 2020 20:04:30 +0000 (21:04 +0100)
committerHeiko Stuebner <heiko@sntech.de>
Sun, 29 Nov 2020 16:33:32 +0000 (17:33 +0100)
In the Rockchip DRM LVDS component driver, the endpoint id provided to
drm_of_find_panel_or_bridge is grabbed from the endpoint's reg property.

However, the property may be missing in the case of a single endpoint.
Initialize the endpoint_id variable to 0 to avoid using an
uninitialized variable in that case.

Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS")
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20201110200430.1713467-1-paul.kocialkowski@bootlin.com
drivers/gpu/drm/rockchip/rockchip_lvds.c

index f292c6a..41edd0a 100644 (file)
@@ -544,7 +544,7 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master,
        struct device_node  *port, *endpoint;
        int ret = 0, child_count = 0;
        const char *name;
-       u32 endpoint_id;
+       u32 endpoint_id = 0;
 
        lvds->drm_dev = drm_dev;
        port = of_graph_get_port_by_id(dev->of_node, 1);