OSDN Git Service

[SCSI] pm80xx: fix problem of pm8001_work_fn reseting incorrect phy device
authorXinHong Zhu <zxh3737@163.com>
Fri, 14 Feb 2014 08:01:28 +0000 (16:01 +0800)
committerJames Bottomley <JBottomley@Parallels.com>
Sat, 15 Mar 2014 17:19:22 +0000 (10:19 -0700)
If a phy device is removed, the device can get error of I/O and HBA maybe
receieve IO_OPEN_CNX_ERROR_IT_NEXUS_LOSS of event which causes pm8001_work_fn
to reset the phy device but in pm8001_task_exec we don't assign a value for
the device field of the ccb and in other case a ccb used have device field
set, when ccb is freed the field device of the ccb don't be set NULL.So there
is possibility of getting another device reset in function mpi_ssp_completion.

Signed-off-by: zhuxh <zxh3737@163.com>
Acked-by: Lindar Liu <lindar_liu@usish.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/pm8001/pm8001_sas.c

index ba3088c..8a44bc9 100644 (file)
@@ -434,6 +434,7 @@ static int pm8001_task_exec(struct sas_task *task, const int num,
                ccb->n_elem = n_elem;
                ccb->ccb_tag = tag;
                ccb->task = t;
+               ccb->device = pm8001_dev;
                switch (t->task_proto) {
                case SAS_PROTOCOL_SMP:
                        rc = pm8001_task_prep_smp(pm8001_ha, ccb);