OSDN Git Service

drm/amd/display : Log DP link training downspread info
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Sun, 9 Apr 2023 17:05:38 +0000 (22:35 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 11 Apr 2023 22:03:45 +0000 (18:03 -0400)
Update the existing log with DP LT downspread info:

[Downstream devices shall support down spreading of the link clock.
The down-spread amplitude shall either be disabled (0.0%) or up to 0.5%,
as written by the upstream device to the DOWNSPREAD_CTRL register
(DPCD 00107h). The modulation frequency range shall be 30 to 33 kHz]

Besides, fix checkpatch warning:

CHECK: Alignment should match open parenthesis

Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c

index 70fc0dd..2d067a4 100644 (file)
@@ -1560,9 +1560,10 @@ bool perform_link_training_with_retries(
        j = 0;
        while (j < attempts && fail_count < (attempts * 10)) {
 
-               DC_LOG_HW_LINK_TRAINING("%s: Beginning link(%d) training attempt %u of %d @ rate(%d) x lane(%d)\n",
-                       __func__, link->link_index, (unsigned int)j + 1, attempts, cur_link_settings.link_rate,
-                       cur_link_settings.lane_count);
+               DC_LOG_HW_LINK_TRAINING("%s: Beginning link(%d) training attempt %u of %d @ rate(%d) x lane(%d) @ spread = %x\n",
+                                       __func__, link->link_index, (unsigned int)j + 1, attempts,
+                                      cur_link_settings.link_rate, cur_link_settings.lane_count,
+                                      cur_link_settings.link_spread);
 
                dp_enable_link_phy(
                        link,
@@ -1640,9 +1641,10 @@ bool perform_link_training_with_retries(
                                break;
                }
 
-               DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d) : fail reason:(%d)\n",
-                       __func__, link->link_index, (unsigned int)j + 1, attempts, cur_link_settings.link_rate,
-                       cur_link_settings.lane_count, status);
+               DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d) @ spread = %x : fail reason:(%d)\n",
+                              __func__, link->link_index, (unsigned int)j + 1, attempts,
+                             cur_link_settings.link_rate, cur_link_settings.lane_count,
+                             cur_link_settings.link_spread, status);
 
                dp_disable_link_phy(link, &pipe_ctx->link_res, signal);