OSDN Git Service

scsi: hisi_sas: Use true/false as input parameter of sas_phy_reset()
authorLuo Jiaxing <luojiaxing@huawei.com>
Fri, 6 Sep 2019 12:55:26 +0000 (20:55 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 11 Sep 2019 02:28:55 +0000 (22:28 -0400)
When calling sas_phy_reset(), we need to specify whether the reset type
is hard reset or link reset - use true/false for clarity.

Link: https://lore.kernel.org/r/1567774537-20003-3-git-send-email-john.garry@huawei.com
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_main.c

index 1731764..59c11f4 100644 (file)
@@ -1762,7 +1762,7 @@ static int hisi_sas_debug_I_T_nexus_reset(struct domain_device *device)
        }
 
        reset_type = (sas_dev->dev_status == HISI_SAS_DEV_INIT ||
-                     !dev_is_sata(device)) ? 1 : 0;
+                     !dev_is_sata(device)) ? true : false;
 
        rc = sas_phy_reset(local_phy, reset_type);
        sas_put_local_phy(local_phy);
@@ -1843,7 +1843,7 @@ static int hisi_sas_lu_reset(struct domain_device *device, u8 *lun)
 
                phy = sas_get_local_phy(device);
 
-               rc = sas_phy_reset(phy, 1);
+               rc = sas_phy_reset(phy, true);
 
                if (rc == 0)
                        hisi_sas_release_task(hisi_hba, device);