OSDN Git Service

pinctrl: imx8ulp: Initialize pin_reg
authorFabio Estevam <festevam@gmail.com>
Fri, 23 Jul 2021 20:32:42 +0000 (17:32 -0300)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 23 Jul 2021 20:52:47 +0000 (22:52 +0200)
The initialization of pin_reg is missing, causing the following build
warning:

drivers/pinctrl/freescale/pinctrl-imx8ulp.c:228:35: warning: 'pin_reg' is used uninitialized in this function [-Wuninitialized]

Initialize pin_reg the same way as it is done on vf610 and imx7ulp
to fix the problem.

Fixes: 16b343e8e0ef ("pinctrl: imx8ulp: Add pinctrl driver support")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/r/20210723203242.88845-1-festevam@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/freescale/pinctrl-imx8ulp.c

index c5db5df..f857259 100644 (file)
@@ -225,6 +225,10 @@ static int imx8ulp_pmx_gpio_set_direction(struct pinctrl_dev *pctldev,
        const struct imx_pin_reg *pin_reg;
        u32 reg;
 
+       pin_reg = &ipctl->pin_regs[offset];
+       if (pin_reg->mux_reg == -1)
+               return -EINVAL;
+
        reg = readl(ipctl->base + pin_reg->mux_reg);
        if (input)
                reg = (reg & ~BM_OBE_ENABLED) | BM_IBE_ENABLED;