OSDN Git Service

media: dvbdev: remove redundant initialization of variable ret
authorColin Ian King <colin.i.king@gmail.com>
Sun, 24 Apr 2022 15:47:20 +0000 (16:47 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 25 Nov 2022 10:01:11 +0000 (10:01 +0000)
Variable ret is being ininitialized with a value that is never read.
The ininitializtion is redundant and can be removed. Move the variable
to the scope it is required.

Link: https://lore.kernel.org/linux-media/20220424154720.1356873-1-colin.i.king@gmail.com
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/dvb-core/dvbdev.c

index 675d877..d5a142e 100644 (file)
@@ -243,7 +243,7 @@ static void dvb_media_device_free(struct dvb_device *dvbdev)
 static int dvb_create_tsout_entity(struct dvb_device *dvbdev,
                                    const char *name, int npads)
 {
-       int i, ret = 0;
+       int i;
 
        dvbdev->tsout_pads = kcalloc(npads, sizeof(*dvbdev->tsout_pads),
                                     GFP_KERNEL);
@@ -260,6 +260,7 @@ static int dvb_create_tsout_entity(struct dvb_device *dvbdev,
        for (i = 0; i < npads; i++) {
                struct media_pad *pads = &dvbdev->tsout_pads[i];
                struct media_entity *entity = &dvbdev->tsout_entity[i];
+               int ret;
 
                entity->name = kasprintf(GFP_KERNEL, "%s #%d", name, i);
                if (!entity->name)