OSDN Git Service

ASoc: rt286: fix boolean tests
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Sat, 5 Jan 2019 02:02:39 +0000 (20:02 -0600)
committerMark Brown <broonie@kernel.org>
Mon, 7 Jan 2019 16:52:00 +0000 (16:52 +0000)
Reported by Coccinelle:
sound/soc/codecs/rt286.c:927:5-7: WARNING: Comparison to bool
sound/soc/codecs/rt286.c:930:5-8: WARNING: Comparison to bool
sound/soc/codecs/rt286.c:299:5-7: WARNING: Comparison to bool
sound/soc/codecs/rt286.c:302:5-8: WARNING: Comparison to bool

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt286.c

index 0b0f748..c9457c2 100644 (file)
@@ -296,10 +296,10 @@ static void rt286_jack_detect_work(struct work_struct *work)
 
        rt286_jack_detect(rt286, &hp, &mic);
 
-       if (hp == true)
+       if (hp)
                status |= SND_JACK_HEADPHONE;
 
-       if (mic == true)
+       if (mic)
                status |= SND_JACK_MICROPHONE;
 
        snd_soc_jack_report(rt286->jack, status,
@@ -924,10 +924,10 @@ static irqreturn_t rt286_irq(int irq, void *data)
        /* Clear IRQ */
        regmap_update_bits(rt286->regmap, RT286_IRQ_CTRL, 0x1, 0x1);
 
-       if (hp == true)
+       if (hp)
                status |= SND_JACK_HEADPHONE;
 
-       if (mic == true)
+       if (mic)
                status |= SND_JACK_MICROPHONE;
 
        snd_soc_jack_report(rt286->jack, status,