OSDN Git Service

net: stmmac: dwmac-sun8i: Remove unnecessary PHY power check
authorSamuel Holland <samuel@sholland.org>
Wed, 17 Feb 2021 04:20:03 +0000 (22:20 -0600)
committerDavid S. Miller <davem@davemloft.net>
Wed, 17 Feb 2021 21:42:56 +0000 (13:42 -0800)
sun8i_dwmac_unpower_internal_phy already checks if the PHY is powered,
so there is no need to do it again here.

Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c

index 8e50501..3c3d0b9 100644 (file)
@@ -1018,10 +1018,8 @@ static void sun8i_dwmac_exit(struct platform_device *pdev, void *priv)
 {
        struct sunxi_priv_data *gmac = priv;
 
-       if (gmac->variant->soc_has_internal_phy) {
-               if (gmac->internal_phy_powered)
-                       sun8i_dwmac_unpower_internal_phy(gmac);
-       }
+       if (gmac->variant->soc_has_internal_phy)
+               sun8i_dwmac_unpower_internal_phy(gmac);
 
        clk_disable_unprepare(gmac->tx_clk);