OSDN Git Service

ic3: off by one in mode_show()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 23 Nov 2018 07:15:05 +0000 (10:15 +0300)
committerBoris Brezillon <boris.brezillon@bootlin.com>
Wed, 5 Dec 2018 16:22:58 +0000 (17:22 +0100)
This should be >= ARRAY_SIZE() to avoid reading one element beyond the
end of the array.

Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
drivers/i3c/master.c

index bda4b96..c39f89d 100644 (file)
@@ -475,7 +475,7 @@ static ssize_t mode_show(struct device *dev,
 
        i3c_bus_normaluse_lock(i3cbus);
        if (i3cbus->mode < 0 ||
-           i3cbus->mode > ARRAY_SIZE(i3c_bus_mode_strings) ||
+           i3cbus->mode >= ARRAY_SIZE(i3c_bus_mode_strings) ||
            !i3c_bus_mode_strings[i3cbus->mode])
                ret = sprintf(buf, "unknown\n");
        else