OSDN Git Service

mtd: nandsim: fix integer widening
authorBrian Norris <computersforpeace@gmail.com>
Tue, 22 Jul 2014 02:07:44 +0000 (19:07 -0700)
committerBrian Norris <computersforpeace@gmail.com>
Tue, 19 Aug 2014 18:53:08 +0000 (11:53 -0700)
This multiplication should be done in 64-bit, not 32-bit.

Caught by Coverity.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/nand/nandsim.c

index 4f0d836..7dc1dd2 100644 (file)
@@ -827,7 +827,7 @@ static int parse_badblocks(struct nandsim *ns, struct mtd_info *mtd)
                        NS_ERR("invalid badblocks.\n");
                        return -EINVAL;
                }
-               offset = erase_block_no * ns->geom.secsz;
+               offset = (loff_t)erase_block_no * ns->geom.secsz;
                if (mtd_block_markbad(mtd, offset)) {
                        NS_ERR("invalid badblocks.\n");
                        return -EINVAL;