OSDN Git Service

scsi: qla4xxx: remvoe unnecessary condition check for mempool_destroy()
authorChengguang Xu <cgxu519@gmx.com>
Sun, 4 Nov 2018 13:57:50 +0000 (21:57 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 7 Nov 2018 02:20:18 +0000 (21:20 -0500)
mempool_destroy() can handle NULL pointer correctly, so there is no
need to check NULL pointer before calling mempool_destroy().

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Acked-by: Manish Rangankar <Manish.Rangankar@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla4xxx/ql4_os.c

index 039950a..1c702cd 100644 (file)
@@ -4160,9 +4160,7 @@ static void qla4xxx_mem_free(struct scsi_qla_host *ha)
        ha->fw_dump_size = 0;
 
        /* Free srb pool. */
-       if (ha->srb_mempool)
-               mempool_destroy(ha->srb_mempool);
-
+       mempool_destroy(ha->srb_mempool);
        ha->srb_mempool = NULL;
 
        dma_pool_destroy(ha->chap_dma_pool);