OSDN Git Service

[SCSI] fcoe: remove redundant checking of netdev->netdev_ops
authorYi Zou <yi.zou@intel.com>
Wed, 21 Oct 2009 23:26:55 +0000 (16:26 -0700)
committerJames Bottomley <James.Bottomley@suse.de>
Fri, 4 Dec 2009 18:00:24 +0000 (12:00 -0600)
Remove the redundant checking of netdev->netdev_ops as it will never be NULL.

Signed-off-by: Yi Zou <yi.zou@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/fcoe/fcoe.c

index 704b8e0..7c89887 100644 (file)
@@ -664,7 +664,7 @@ static int fcoe_ddp_setup(struct fc_lport *lp, u16 xid,
 {
        struct net_device *n = fcoe_netdev(lp);
 
-       if (n->netdev_ops && n->netdev_ops->ndo_fcoe_ddp_setup)
+       if (n->netdev_ops->ndo_fcoe_ddp_setup)
                return n->netdev_ops->ndo_fcoe_ddp_setup(n, xid, sgl, sgc);
 
        return 0;
@@ -681,7 +681,7 @@ static int fcoe_ddp_done(struct fc_lport *lp, u16 xid)
 {
        struct net_device *n = fcoe_netdev(lp);
 
-       if (n->netdev_ops && n->netdev_ops->ndo_fcoe_ddp_done)
+       if (n->netdev_ops->ndo_fcoe_ddp_done)
                return n->netdev_ops->ndo_fcoe_ddp_done(n, xid);
        return 0;
 }