OSDN Git Service

net: mtk_eth_soc: mark as a legacy_pre_march2020 driver
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thu, 9 Dec 2021 13:11:43 +0000 (13:11 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 9 Dec 2021 19:21:03 +0000 (11:21 -0800)
mtk_eth_soc has not been updated for commit 7cceb599d15d ("net: phylink:
avoid mac_config calls"), and makes use of state->speed and
state->duplex in contravention of the phylink documentation. This makes
reliant on the legacy behaviours, so mark it as a legacy driver.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mediatek/mtk_eth_soc.c

index de4152e..a068cf5 100644 (file)
@@ -2923,6 +2923,10 @@ static int mtk_add_mac(struct mtk_eth *eth, struct device_node *np)
 
        mac->phylink_config.dev = &eth->netdev[id]->dev;
        mac->phylink_config.type = PHYLINK_NETDEV;
+       /* This driver makes use of state->speed/state->duplex in
+        * mac_config
+        */
+       mac->phylink_config.legacy_pre_march2020 = true;
        mac->phylink_config.mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE |
                MAC_10 | MAC_100 | MAC_1000 | MAC_2500FD;