VCS: Handle empty arguments in EditorParameterWidgets

Task-number: QTCREATORBUG-6251
Change-Id: I833bcecf295b7191df1916a658b16f008f69f902
Reviewed-on: http://codereview.qt-project.org/6164
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>

diff --git a/src/plugins/vcsbase/vcsbaseeditorparameterwidget.cpp b/src/plugins/vcsbase/vcsbaseeditorparameterwidget.cpp
index 961321a..a15e32f 100644 (file)
--- a/src/plugins/vcsbase/vcsbaseeditorparameterwidget.cpp
+++ b/src/plugins/vcsbase/vcsbaseeditorparameterwidget.cpp
@@ -270,8 +270,12 @@ const QList<VCSBaseEditorParameterWidget::OptionMapping> &VCSBaseEditorParameter
 QStringList VCSBaseEditorParameterWidget::argumentsForOption(const OptionMapping &mapping) const
 {
     const QToolButton *tb = qobject_cast<const QToolButton *>(mapping.widget);
-    if (tb && tb->isChecked())
-        return QStringList(mapping.optionName);
+    if (tb && tb->isChecked()) {
+        if (!mapping.optionName.isEmpty())
+            return QStringList(mapping.optionName);
+        else
+            return QStringList();
+    }
 
     const QComboBox *cb = qobject_cast<const QComboBox *>(mapping.widget);
     if (cb) {