OSDN Git Service

[libc][NFC] Skip adding dummy targets for skipped unit tests.
authorSiva Chandra <sivachandra@google.com>
Tue, 15 Dec 2020 01:51:13 +0000 (17:51 -0800)
committerSiva Chandra <sivachandra@google.com>
Tue, 15 Dec 2020 01:52:47 +0000 (17:52 -0800)
libc/cmake/modules/LLVMLibCTestRules.cmake
libc/test/src/math/CMakeLists.txt

index 33dc2cc..421e1a1 100644 (file)
@@ -111,14 +111,6 @@ function(add_libc_unittest target_name)
     set(msg "Skipping unittest ${fq_target_name} as it has missing deps: "
             "${skipped_entrypoints_list}.")
     message(STATUS ${msg})
-    add_custom_target(${fq_target_name})
-
-    # A post build custom command is used to avoid running the command always.
-    add_custom_command(
-      TARGET ${fq_target_name}
-      POST_BUILD
-      COMMAND ${CMAKE_COMMAND} -E echo ${msg}
-    )
     return()
   endif()
 
index 44abc40..7475be1 100644 (file)
@@ -18,6 +18,9 @@ function(add_fp_unittest name)
 
   add_libc_unittest(${name} ${MATH_UNITTEST_UNPARSED_ARGUMENTS})
   get_fq_target_name(${name} fq_target_name)
+  if (NOT TARGET ${fq_target_name})
+    return()
+  endif()
   if(MATH_UNITTEST_NEED_MPFR)
     target_link_libraries(${fq_target_name} PRIVATE libcMPFRWrapper -lmpfr -lgmp)
   endif()