[Refactor] VS2022 で出ているコンパイル警告を解消した (v3.0.0 β12)

diff --git a/src/io-dump/special-class-dump.cpp b/src/io-dump/special-class-dump.cpp
index 69463b4..7abc73f 100644 (file)
--- a/src/io-dump/special-class-dump.cpp
+++ b/src/io-dump/special-class-dump.cpp
@@ -107,7 +107,7 @@ static void dump_smith(PlayerType *player_ptr, FILE *fff)
     fprintf(fff, _("\n\n  [手に入れたエッセンス]\n\n", "\n\n  [Get Essence]\n\n"));
     fprintf(fff, _("エッセンス   個数     エッセンス   個数     エッセンス   個数", "Essence      Num      Essence      Num      Essence      Num "));
 
-    auto essences = Smith::get_essence_list();
+    const auto &essences = Smith::get_essence_list();
     auto n = essences.size();
     std::vector<int> amounts;
     std::transform(essences.begin(), essences.end(), std::back_inserter(amounts),
@@ -174,12 +174,8 @@ static void dump_blue_mage(PlayerType *player_ptr, FILE *fff)
         return;
     }
 
-    char p[60][80];
-    for (int i = 0; i < 60; i++) {
-        p[i][0] = '\0';
-    }
-
-    int col = 0;
+    char p[60][80]{};
+    auto col = 0;
     strcat(p[col], _("\n\n  [学習済みの青魔法]\n", "\n\n  [Learned Blue Magic]\n"));
 
     for (auto SpellProcessType : BLUE_MAGIC_TYPE_LIST) {
@@ -192,13 +188,13 @@ static void dump_blue_mage(PlayerType *player_ptr, FILE *fff)
         EnumClassFlagGroup<MonsterAbilityType>::get_flags(learnt_magic.ability_flags, std::back_inserter(learnt_spells));
 
         col++;
-        bool pcol = false;
+        auto pcol = false;
         strcat(p[col], "       ");
 
         for (auto spell : learnt_spells) {
             pcol = true;
-            int l1 = strlen(p[col]);
-            int l2 = strlen(monster_powers_short.at(spell));
+            auto l1 = strlen(p[col]);
+            auto l2 = strlen(monster_powers_short.at(spell));
             if ((l1 + l2) >= 75) {
                 strcat(p[col], "\n");
                 col++;

diff --git a/src/io/interpret-pref-file.cpp b/src/io/interpret-pref-file.cpp
index 84faa69..7daf32e 100644 (file)
--- a/src/io/interpret-pref-file.cpp
+++ b/src/io/interpret-pref-file.cpp
@@ -425,17 +425,16 @@ static errr decide_template_modifier(int tok, char **zz)
  */
 static errr interpret_macro_keycodes(int tok, char **zz)
 {
-    char buf_aux[MAX_MACRO_CHARS];
-    char *t, *s;
+    char buf_aux[MAX_MACRO_CHARS]{};
     if (max_macrotrigger >= MAX_MACRO_TRIG) {
         msg_print(_("マクロトリガーの設定が多すぎます!", "Too many macro triggers!"));
         return 1;
     }
 
-    int m = max_macrotrigger;
+    auto m = max_macrotrigger;
     max_macrotrigger++;
-    t = buf_aux;
-    s = zz[0];
+    auto *t = buf_aux;
+    auto *s = zz[0];
     while (*s) {
         if ('\\' == *s) {
             s++;

diff --git a/src/save/save.cpp b/src/save/save.cpp
index f4ff5ee..76b8261 100644 (file)
--- a/src/save/save.cpp
+++ b/src/save/save.cpp
@@ -312,10 +312,11 @@ bool save_player(PlayerType *player_ptr, SaveType type)
     safe_setuid_grab();
     fd_kill(savefile_new);
     if (type == SaveType::DEBUG) {
-        const auto debug_save_dir = std::filesystem::path(debug_savefile).remove_filename();
+        const std::filesystem::path debug_save_dir = std::filesystem::path(debug_savefile).remove_filename();
         std::error_code ec;
         std::filesystem::create_directory(debug_save_dir, ec);
     }
+
     safe_setuid_drop();
     w_ptr->update_playtime();
     auto result = false;