OSDN Git Service

liquidio: remove unnecessary NULL check before kfree in delete_glists
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Tue, 17 Oct 2017 18:59:20 +0000 (13:59 -0500)
committerDavid S. Miller <davem@davemloft.net>
Thu, 19 Oct 2017 12:27:54 +0000 (13:27 +0100)
NULL check before freeing functions like kfree is not needed.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Felix Manlunas <felix.manlunas@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c

index 2e993ce..e4a112c 100644 (file)
@@ -435,8 +435,7 @@ static void delete_glists(struct lio *lio)
                do {
                        g = (struct octnic_gather *)
                            list_delete_head(&lio->glist[i]);
-                       if (g)
-                               kfree(g);
+                       kfree(g);
                } while (g);
 
                if (lio->glists_virt_base && lio->glists_virt_base[i] &&