OSDN Git Service

HID: usbmouse: Avoid GFP_ATOMIC when GFP_KERNEL is possible
authorHyeonggon Yoo <42.hyeyoo@gmail.com>
Mon, 24 May 2021 14:57:43 +0000 (23:57 +0900)
committerJiri Kosina <jkosina@suse.cz>
Wed, 26 May 2021 11:11:23 +0000 (13:11 +0200)
probe in usb don't need to be atomic. So GFP_KERNEL can be used here,
instead of GFP_ATOMIC.

Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/usbhid/usbmouse.c

index 073127e..c893320 100644 (file)
@@ -130,7 +130,7 @@ static int usb_mouse_probe(struct usb_interface *intf, const struct usb_device_i
        if (!mouse || !input_dev)
                goto fail1;
 
-       mouse->data = usb_alloc_coherent(dev, 8, GFP_ATOMIC, &mouse->data_dma);
+       mouse->data = usb_alloc_coherent(dev, 8, GFP_KERNEL, &mouse->data_dma);
        if (!mouse->data)
                goto fail1;