OSDN Git Service

KVM: s390: fix signal handling
authorChristian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
Wed, 20 May 2009 13:34:56 +0000 (15:34 +0200)
committerAvi Kivity <avi@redhat.com>
Thu, 10 Sep 2009 05:32:42 +0000 (08:32 +0300)
If signal pending is true we exit without updating kvm_run, userspace
currently just does nothing and jumps to kvm_run again.
Since we did not set an exit_reason we might end up with a random one
(whatever was the last exit). Therefore it was possible to e.g. jump to
the psw position the last real interruption set.
Setting the INTR exit reason ensures that no old psw data is swapped
in on reentry.

Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
arch/s390/kvm/kvm-s390.c

index 1d65f62..5c1c302 100644 (file)
@@ -527,8 +527,10 @@ rerun_vcpu:
        if (rc == SIE_INTERCEPT_RERUNVCPU)
                goto rerun_vcpu;
 
-       if (signal_pending(current) && !rc)
+       if (signal_pending(current) && !rc) {
+               kvm_run->exit_reason = KVM_EXIT_INTR;
                rc = -EINTR;
+       }
 
        if (rc == -ENOTSUPP) {
                /* intercept cannot be handled in-kernel, prepare kvm-run */