OSDN Git Service

drm/i915/gmch: mass rename dev_priv to i915
authorJani Nikula <jani.nikula@intel.com>
Tue, 17 Jan 2023 12:33:08 +0000 (14:33 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 25 Jan 2023 11:52:33 +0000 (13:52 +0200)
Prefer the contemporary naming.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/3e4aaadeb4a027165f5724027963aa5e8d747190.1673958757.git.jani.nikula@intel.com
drivers/gpu/drm/i915/soc/intel_gmch.c

index 75916aa..d5fbb79 100644 (file)
@@ -17,33 +17,32 @@ static void intel_gmch_bridge_release(struct drm_device *dev, void *bridge)
        pci_dev_put(bridge);
 }
 
-int intel_gmch_bridge_setup(struct drm_i915_private *dev_priv)
+int intel_gmch_bridge_setup(struct drm_i915_private *i915)
 {
-       int domain = pci_domain_nr(to_pci_dev(dev_priv->drm.dev)->bus);
+       int domain = pci_domain_nr(to_pci_dev(i915->drm.dev)->bus);
 
-       dev_priv->gmch.pdev =
-               pci_get_domain_bus_and_slot(domain, 0, PCI_DEVFN(0, 0));
-       if (!dev_priv->gmch.pdev) {
-               drm_err(&dev_priv->drm, "bridge device not found\n");
+       i915->gmch.pdev = pci_get_domain_bus_and_slot(domain, 0, PCI_DEVFN(0, 0));
+       if (!i915->gmch.pdev) {
+               drm_err(&i915->drm, "bridge device not found\n");
                return -EIO;
        }
 
-       return drmm_add_action_or_reset(&dev_priv->drm, intel_gmch_bridge_release,
-                                       dev_priv->gmch.pdev);
+       return drmm_add_action_or_reset(&i915->drm, intel_gmch_bridge_release,
+                                       i915->gmch.pdev);
 }
 
 /* Allocate space for the MCH regs if needed, return nonzero on error */
 static int
-intel_alloc_mchbar_resource(struct drm_i915_private *dev_priv)
+intel_alloc_mchbar_resource(struct drm_i915_private *i915)
 {
-       int reg = GRAPHICS_VER(dev_priv) >= 4 ? MCHBAR_I965 : MCHBAR_I915;
+       int reg = GRAPHICS_VER(i915) >= 4 ? MCHBAR_I965 : MCHBAR_I915;
        u32 temp_lo, temp_hi = 0;
        u64 mchbar_addr;
        int ret;
 
-       if (GRAPHICS_VER(dev_priv) >= 4)
-               pci_read_config_dword(dev_priv->gmch.pdev, reg + 4, &temp_hi);
-       pci_read_config_dword(dev_priv->gmch.pdev, reg, &temp_lo);
+       if (GRAPHICS_VER(i915) >= 4)
+               pci_read_config_dword(i915->gmch.pdev, reg + 4, &temp_hi);
+       pci_read_config_dword(i915->gmch.pdev, reg, &temp_lo);
        mchbar_addr = ((u64)temp_hi << 32) | temp_lo;
 
        /* If ACPI doesn't have it, assume we need to allocate it ourselves */
@@ -54,46 +53,46 @@ intel_alloc_mchbar_resource(struct drm_i915_private *dev_priv)
 #endif
 
        /* Get some space for it */
-       dev_priv->gmch.mch_res.name = "i915 MCHBAR";
-       dev_priv->gmch.mch_res.flags = IORESOURCE_MEM;
-       ret = pci_bus_alloc_resource(dev_priv->gmch.pdev->bus,
-                                    &dev_priv->gmch.mch_res,
+       i915->gmch.mch_res.name = "i915 MCHBAR";
+       i915->gmch.mch_res.flags = IORESOURCE_MEM;
+       ret = pci_bus_alloc_resource(i915->gmch.pdev->bus,
+                                    &i915->gmch.mch_res,
                                     MCHBAR_SIZE, MCHBAR_SIZE,
                                     PCIBIOS_MIN_MEM,
                                     0, pcibios_align_resource,
-                                    dev_priv->gmch.pdev);
+                                    i915->gmch.pdev);
        if (ret) {
-               drm_dbg(&dev_priv->drm, "failed bus alloc: %d\n", ret);
-               dev_priv->gmch.mch_res.start = 0;
+               drm_dbg(&i915->drm, "failed bus alloc: %d\n", ret);
+               i915->gmch.mch_res.start = 0;
                return ret;
        }
 
-       if (GRAPHICS_VER(dev_priv) >= 4)
-               pci_write_config_dword(dev_priv->gmch.pdev, reg + 4,
-                                      upper_32_bits(dev_priv->gmch.mch_res.start));
+       if (GRAPHICS_VER(i915) >= 4)
+               pci_write_config_dword(i915->gmch.pdev, reg + 4,
+                                      upper_32_bits(i915->gmch.mch_res.start));
 
-       pci_write_config_dword(dev_priv->gmch.pdev, reg,
-                              lower_32_bits(dev_priv->gmch.mch_res.start));
+       pci_write_config_dword(i915->gmch.pdev, reg,
+                              lower_32_bits(i915->gmch.mch_res.start));
        return 0;
 }
 
 /* Setup MCHBAR if possible, return true if we should disable it again */
-void intel_gmch_bar_setup(struct drm_i915_private *dev_priv)
+void intel_gmch_bar_setup(struct drm_i915_private *i915)
 {
-       int mchbar_reg = GRAPHICS_VER(dev_priv) >= 4 ? MCHBAR_I965 : MCHBAR_I915;
+       int mchbar_reg = GRAPHICS_VER(i915) >= 4 ? MCHBAR_I965 : MCHBAR_I915;
        u32 temp;
        bool enabled;
 
-       if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
+       if (IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915))
                return;
 
-       dev_priv->gmch.mchbar_need_disable = false;
+       i915->gmch.mchbar_need_disable = false;
 
-       if (IS_I915G(dev_priv) || IS_I915GM(dev_priv)) {
-               pci_read_config_dword(dev_priv->gmch.pdev, DEVEN, &temp);
+       if (IS_I915G(i915) || IS_I915GM(i915)) {
+               pci_read_config_dword(i915->gmch.pdev, DEVEN, &temp);
                enabled = !!(temp & DEVEN_MCHBAR_EN);
        } else {
-               pci_read_config_dword(dev_priv->gmch.pdev, mchbar_reg, &temp);
+               pci_read_config_dword(i915->gmch.pdev, mchbar_reg, &temp);
                enabled = temp & 1;
        }
 
@@ -101,45 +100,45 @@ void intel_gmch_bar_setup(struct drm_i915_private *dev_priv)
        if (enabled)
                return;
 
-       if (intel_alloc_mchbar_resource(dev_priv))
+       if (intel_alloc_mchbar_resource(i915))
                return;
 
-       dev_priv->gmch.mchbar_need_disable = true;
+       i915->gmch.mchbar_need_disable = true;
 
        /* Space is allocated or reserved, so enable it. */
-       if (IS_I915G(dev_priv) || IS_I915GM(dev_priv)) {
-               pci_write_config_dword(dev_priv->gmch.pdev, DEVEN,
+       if (IS_I915G(i915) || IS_I915GM(i915)) {
+               pci_write_config_dword(i915->gmch.pdev, DEVEN,
                                       temp | DEVEN_MCHBAR_EN);
        } else {
-               pci_read_config_dword(dev_priv->gmch.pdev, mchbar_reg, &temp);
-               pci_write_config_dword(dev_priv->gmch.pdev, mchbar_reg, temp | 1);
+               pci_read_config_dword(i915->gmch.pdev, mchbar_reg, &temp);
+               pci_write_config_dword(i915->gmch.pdev, mchbar_reg, temp | 1);
        }
 }
 
-void intel_gmch_bar_teardown(struct drm_i915_private *dev_priv)
+void intel_gmch_bar_teardown(struct drm_i915_private *i915)
 {
-       int mchbar_reg = GRAPHICS_VER(dev_priv) >= 4 ? MCHBAR_I965 : MCHBAR_I915;
+       int mchbar_reg = GRAPHICS_VER(i915) >= 4 ? MCHBAR_I965 : MCHBAR_I915;
 
-       if (dev_priv->gmch.mchbar_need_disable) {
-               if (IS_I915G(dev_priv) || IS_I915GM(dev_priv)) {
+       if (i915->gmch.mchbar_need_disable) {
+               if (IS_I915G(i915) || IS_I915GM(i915)) {
                        u32 deven_val;
 
-                       pci_read_config_dword(dev_priv->gmch.pdev, DEVEN,
+                       pci_read_config_dword(i915->gmch.pdev, DEVEN,
                                              &deven_val);
                        deven_val &= ~DEVEN_MCHBAR_EN;
-                       pci_write_config_dword(dev_priv->gmch.pdev, DEVEN,
+                       pci_write_config_dword(i915->gmch.pdev, DEVEN,
                                               deven_val);
                } else {
                        u32 mchbar_val;
 
-                       pci_read_config_dword(dev_priv->gmch.pdev, mchbar_reg,
+                       pci_read_config_dword(i915->gmch.pdev, mchbar_reg,
                                              &mchbar_val);
                        mchbar_val &= ~1;
-                       pci_write_config_dword(dev_priv->gmch.pdev, mchbar_reg,
+                       pci_write_config_dword(i915->gmch.pdev, mchbar_reg,
                                               mchbar_val);
                }
        }
 
-       if (dev_priv->gmch.mch_res.start)
-               release_resource(&dev_priv->gmch.mch_res);
+       if (i915->gmch.mch_res.start)
+               release_resource(&i915->gmch.mch_res);
 }