OSDN Git Service

NTB: ntb_perf: Disable NTB link after clearing peer XLAT registers
authorSanjay R Mehta <sanju.mehta@amd.com>
Fri, 15 Feb 2019 09:20:30 +0000 (09:20 +0000)
committerJon Mason <jdmason@kudzu.us>
Thu, 13 Jun 2019 12:58:01 +0000 (08:58 -0400)
If ntb link disabled before clearing peer's XLAT register, the clearing
won't have any effect since the link is already down. So modified the
sequence so that the link is down only towards the end of the function
after clearing the XLAT register

Signed-off-by: Sanjay R Mehta <sanju.mehta@amd.com>
Acked-by: Allen Hubbe <allenbh@gmail.com>
Acked-by: Logan Gunthorpe <logang@deltatee.com>
Acked-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
drivers/ntb/test/ntb_perf.c

index 5ed8437..32a70b6 100644 (file)
@@ -734,8 +734,6 @@ static void perf_disable_service(struct perf_ctx *perf)
 {
        int pidx;
 
-       ntb_link_disable(perf->ntb);
-
        if (perf->cmd_send == perf_msg_cmd_send) {
                u64 inbits;
 
@@ -752,6 +750,8 @@ static void perf_disable_service(struct perf_ctx *perf)
 
        for (pidx = 0; pidx < perf->pcnt; pidx++)
                flush_work(&perf->peers[pidx].service);
+
+       ntb_link_disable(perf->ntb);
 }
 
 /*==============================================================================