OSDN Git Service

scsi: aic94xx: Remove unnecessary null check
authorYueHaibing <yuehaibing@huawei.com>
Thu, 11 Jul 2019 14:15:39 +0000 (22:15 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 30 Jul 2019 16:12:59 +0000 (12:12 -0400)
kmem_cache_destroy() can handle NULL pointer correctly, so there is no need
to check NULL pointer before calling kmem_cache_destroy().

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/aic94xx/aic94xx_init.c

index 261d8e4..f5781e3 100644 (file)
@@ -565,8 +565,7 @@ static void asd_destroy_ha_caches(struct asd_ha_struct *asd_ha)
        if (asd_ha->hw_prof.scb_ext)
                asd_free_coherent(asd_ha, asd_ha->hw_prof.scb_ext);
 
-       if (asd_ha->hw_prof.ddb_bitmap)
-               kfree(asd_ha->hw_prof.ddb_bitmap);
+       kfree(asd_ha->hw_prof.ddb_bitmap);
        asd_ha->hw_prof.ddb_bitmap = NULL;
 
        for (i = 0; i < ASD_MAX_PHYS; i++) {
@@ -641,12 +640,10 @@ Err:
 
 static void asd_destroy_global_caches(void)
 {
-       if (asd_dma_token_cache)
-               kmem_cache_destroy(asd_dma_token_cache);
+       kmem_cache_destroy(asd_dma_token_cache);
        asd_dma_token_cache = NULL;
 
-       if (asd_ascb_cache)
-               kmem_cache_destroy(asd_ascb_cache);
+       kmem_cache_destroy(asd_ascb_cache);
        asd_ascb_cache = NULL;
 }