OSDN Git Service

media: atomisp: add a default case at __get_frame_info()
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 2 Nov 2021 06:49:21 +0000 (06:49 +0000)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 15 Nov 2021 08:11:44 +0000 (08:11 +0000)
The switch() logic there misses a break and a default case.
That makes it more prone to problems as the code change.

Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_compat_css20.c

index 1309855..a8972b2 100644 (file)
@@ -2691,9 +2691,11 @@ static int __get_frame_info(struct atomisp_sub_device *asd,
                *info = p_info.output_info[1];
                dev_dbg(isp->dev, "getting second main frame info.\n");
                break;
+       default:
        case ATOMISP_CSS_RAW_FRAME:
                *info = p_info.raw_output_info;
                dev_dbg(isp->dev, "getting raw frame info.\n");
+               break;
        }
        dev_dbg(isp->dev, "get frame info: w=%d, h=%d, num_invalid_frames %d.\n",
                info->res.width, info->res.height, p_info.num_invalid_frames);