OSDN Git Service

firewire: replace tricky statement by two simple ones
authorUwe Kleine-König <uwe@kleine-koenig.org>
Tue, 26 Jan 2021 22:14:44 +0000 (23:14 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 9 Feb 2021 11:16:20 +0000 (12:16 +0100)
struct fw_driver::remove returns void, still the comma expression's value
is zero. This is harder to parse than necessary, so replace the single
expression by two easier ones.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Link: https://lore.kernel.org/r/20210126221444.713837-1-uwe@kleine-koenig.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firewire/core-device.c

index 80db43a..6821698 100644 (file)
@@ -192,7 +192,9 @@ static int fw_unit_remove(struct device *dev)
        struct fw_driver *driver =
                        container_of(dev->driver, struct fw_driver, driver);
 
-       return driver->remove(fw_unit(dev)), 0;
+       driver->remove(fw_unit(dev));
+
+       return 0;
 }
 
 static int get_modalias(struct fw_unit *unit, char *buffer, size_t buffer_size)