OSDN Git Service

blk-iocost: change div64_u64 to DIV64_U64_ROUND_UP in ioc_refresh_params()
authorLi Nan <linan122@huawei.com>
Tue, 17 Jan 2023 07:08:06 +0000 (15:08 +0800)
committerJens Axboe <axboe@kernel.dk>
Sun, 29 Jan 2023 22:18:34 +0000 (15:18 -0700)
vrate_min is calculated by DIV64_U64_ROUND_UP, but vrate_max is calculated
by div64_u64. Vrate_min may be 1 greater than vrate_max if the input
values min and max of cost.qos are equal.

Signed-off-by: Li Nan <linan122@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20230117070806.3857142-6-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-iocost.c

index a4f1956..9694394 100644 (file)
@@ -933,8 +933,8 @@ static bool ioc_refresh_params(struct ioc *ioc, bool force)
 
        ioc->vrate_min = DIV64_U64_ROUND_UP((u64)ioc->params.qos[QOS_MIN] *
                                            VTIME_PER_USEC, MILLION);
-       ioc->vrate_max = div64_u64((u64)ioc->params.qos[QOS_MAX] *
-                                  VTIME_PER_USEC, MILLION);
+       ioc->vrate_max = DIV64_U64_ROUND_UP((u64)ioc->params.qos[QOS_MAX] *
+                                           VTIME_PER_USEC, MILLION);
 
        return true;
 }