OSDN Git Service

mfd: arizona: Remove redundant register sync
authorCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Wed, 22 Apr 2015 13:34:48 +0000 (14:34 +0100)
committerLee Jones <lee.jones@linaro.org>
Mon, 22 Jun 2015 11:25:03 +0000 (12:25 +0100)
This soft reset used to be located after the register patch had been
applied, but has since moved to before the patch is applied. At the new
location there is no requirement to do a register sync as no register
writes will have happened yet.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/arizona-core.c

index 6ca6dfa..aed43a5 100644 (file)
@@ -777,8 +777,6 @@ int arizona_dev_init(struct arizona *arizona)
 
        /* If we have a /RESET GPIO we'll already be reset */
        if (!arizona->pdata.reset) {
-               regcache_mark_dirty(arizona->regmap);
-
                ret = regmap_write(arizona->regmap, ARIZONA_SOFTWARE_RESET, 0);
                if (ret != 0) {
                        dev_err(dev, "Failed to reset device: %d\n", ret);
@@ -786,12 +784,6 @@ int arizona_dev_init(struct arizona *arizona)
                }
 
                msleep(1);
-
-               ret = regcache_sync(arizona->regmap);
-               if (ret != 0) {
-                       dev_err(dev, "Failed to sync device: %d\n", ret);
-                       goto err_reset;
-               }
        }
 
        /* Ensure device startup is complete */