OSDN Git Service

PCI: brcmstb: Don't clk_put() a managed clock
authorJim Quinlan <jquinlan@broadcom.com>
Thu, 7 May 2020 20:15:40 +0000 (16:15 -0400)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Mon, 11 May 2020 10:46:39 +0000 (11:46 +0100)
clk_put() was being invoked on a clock obtained by
devm_clk_get_optional().

Link: https://lore.kernel.org/r/20200507201544.43432-2-james.quinlan@broadcom.com
Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
drivers/pci/controller/pcie-brcmstb.c

index 9aa4cdc..e847528 100644 (file)
@@ -900,7 +900,6 @@ static void __brcm_pcie_remove(struct brcm_pcie *pcie)
        brcm_msi_remove(pcie);
        brcm_pcie_turn_off(pcie);
        clk_disable_unprepare(pcie->clk);
-       clk_put(pcie->clk);
 }
 
 static int brcm_pcie_remove(struct platform_device *pdev)