OSDN Git Service

greybus: svc: add missing boot-status error message
authorJohan Hovold <johan@hovoldconsulting.com>
Mon, 7 Dec 2015 14:05:28 +0000 (15:05 +0100)
committerGreg Kroah-Hartman <gregkh@google.com>
Mon, 7 Dec 2015 19:34:46 +0000 (14:34 -0500)
Make sure to print an error message when aborting hotplug processing due
to failure to clear the interface boot status.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/svc.c

index 5ae64d7..2a8f79e 100644 (file)
@@ -393,8 +393,11 @@ static void gb_svc_process_intf_hotplug(struct gb_operation *operation)
        }
 
        ret = gb_svc_read_and_clear_module_boot_status(intf);
-       if (ret)
+       if (ret) {
+               dev_err(&svc->dev, "failed to clear boot status of interface %u: %d\n",
+                               intf_id, ret);
                goto destroy_interface;
+       }
 
        intf->unipro_mfg_id = le32_to_cpu(request->data.unipro_mfg_id);
        intf->unipro_prod_id = le32_to_cpu(request->data.unipro_prod_id);