OSDN Git Service

Disabling the debugger wait dialog by default with Vulkan
authorAlexis Hetu <sugoi@google.com>
Tue, 13 Nov 2018 18:28:20 +0000 (13:28 -0500)
committerAlexis Hétu <sugoi@google.com>
Tue, 13 Nov 2018 19:27:50 +0000 (19:27 +0000)
For some reason, the Vulkan Loader prevents any dialog window from
popping up, which means that loading the SwiftShader Vulkan DLL in
Debug was always failing, unless a debugger was already attached
(as is the case when running from within Visual Studio). The
debugger wait dialog can still be easily enabled locally by setting
the DEBUGGER_WAIT_DIALOG environment variable.

Bug b/116336664

Change-Id: I7ce596c753506c806bf6b159685a72d0372f949a
Reviewed-on: https://swiftshader-review.googlesource.com/c/22488
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
src/Vulkan/vulkan.vcxproj

index 5258dc6..89062a8 100644 (file)
@@ -83,7 +83,7 @@ copy "$(OutDir)vk_swiftshader.dll" "$(SolutionDir)out\$(Configuration)_$(Platfor
       <Optimization>Disabled</Optimization>\r
       <SDLCheck>true</SDLCheck>\r
       <AdditionalIncludeDirectories>$(SolutionDir)include;$(SolutionDir)src;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>\r
-      <PreprocessorDefinitions>_DEBUG;_WINDOWS;_USRDLL;_CRT_SECURE_NO_DEPRECATE;NOMINMAX;DEBUGGER_WAIT_DIALOG;%(PreprocessorDefinitions)</PreprocessorDefinitions>\r
+      <PreprocessorDefinitions>_DEBUG;_WINDOWS;_USRDLL;_CRT_SECURE_NO_DEPRECATE;NOMINMAX;%(PreprocessorDefinitions)</PreprocessorDefinitions>\r
       <RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>\r
       <AdditionalOptions>/permissive- %(AdditionalOptions)</AdditionalOptions>\r
       <TreatSpecificWarningsAsErrors>4018;5038;4838</TreatSpecificWarningsAsErrors>\r