OSDN Git Service

powerpc/opal: Assign numbers to OPAL_MSG macros of enum opal_msg_type
authorVipin K Parashar <vipin@linux.vnet.ibm.com>
Mon, 31 Aug 2015 23:22:43 +0000 (04:52 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 11 Apr 2016 10:30:45 +0000 (20:30 +1000)
This patch assigns numbers to OPAL_MSG macros of enum opal_msg_type
to prevent accidental insertion of any new value in between and thus
break OPAL API. This is also helpful while backporting mainline kernel
changes to distros which run downlevel kernel and thus don't have all
OPAL messages defined, avoiding unnecessary bugs due to enum values
order mismatch.

Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
Acked-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/include/asm/opal-api.h

index f8faaae..9bb8ddf 100644 (file)
@@ -368,16 +368,16 @@ enum OpalLPCAddressType {
 };
 
 enum opal_msg_type {
-       OPAL_MSG_ASYNC_COMP = 0,        /* params[0] = token, params[1] = rc,
+       OPAL_MSG_ASYNC_COMP     = 0,    /* params[0] = token, params[1] = rc,
                                         * additional params function-specific
                                         */
-       OPAL_MSG_MEM_ERR,
-       OPAL_MSG_EPOW,
-       OPAL_MSG_SHUTDOWN,              /* params[0] = 1 reboot, 0 shutdown */
-       OPAL_MSG_HMI_EVT,
-       OPAL_MSG_DPO,
-       OPAL_MSG_PRD,
-       OPAL_MSG_OCC,
+       OPAL_MSG_MEM_ERR        = 1,
+       OPAL_MSG_EPOW           = 2,
+       OPAL_MSG_SHUTDOWN       = 3,    /* params[0] = 1 reboot, 0 shutdown */
+       OPAL_MSG_HMI_EVT        = 4,
+       OPAL_MSG_DPO            = 5,
+       OPAL_MSG_PRD            = 6,
+       OPAL_MSG_OCC            = 7,
        OPAL_MSG_TYPE_MAX,
 };