OSDN Git Service

perf/x86/intel/cqm: Use proper data types
authorThomas Gleixner <tglx@linutronix.de>
Tue, 19 May 2015 00:00:51 +0000 (00:00 +0000)
committerIngo Molnar <mingo@kernel.org>
Wed, 27 May 2015 07:17:39 +0000 (09:17 +0200)
'int' is really not a proper data type for an MSR. Use u32 to make it
clear that we are dealing with a 32-bit unsigned hardware value.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Matt Fleming <matt.fleming@intel.com>
Cc: Kanaka Juvva <kanaka.d.juvva@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vikas Shivappa <vikas.shivappa@linux.intel.com>
Cc: Will Auld <will.auld@intel.com>
Link: http://lkml.kernel.org/r/20150518235149.919350144@linutronix.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/cpu/perf_event_intel_cqm.c
include/linux/perf_event.h

index 572582e..3e9a7fb 100644 (file)
@@ -18,7 +18,7 @@ static unsigned int cqm_l3_scale; /* supposedly cacheline size */
 
 struct intel_cqm_state {
        raw_spinlock_t          lock;
-       int                     rmid;
+       u32                     rmid;
        int                     cnt;
 };
 
@@ -962,7 +962,7 @@ out:
 static void intel_cqm_event_start(struct perf_event *event, int mode)
 {
        struct intel_cqm_state *state = this_cpu_ptr(&cqm_state);
-       unsigned int rmid = event->hw.cqm_rmid;
+       u32 rmid = event->hw.cqm_rmid;
        unsigned long flags;
 
        if (!(event->hw.cqm_state & PERF_HES_STOPPED))
index 248f782..0658002 100644 (file)
@@ -120,7 +120,7 @@ struct hw_perf_event {
                };
                struct { /* intel_cqm */
                        int                     cqm_state;
-                       int                     cqm_rmid;
+                       u32                     cqm_rmid;
                        struct list_head        cqm_events_entry;
                        struct list_head        cqm_groups_entry;
                        struct list_head        cqm_group_entry;