OSDN Git Service

dgnc: break-related ioctls won't reach ->ioctl()
authorAl Viro <viro@zeniv.linux.org.uk>
Wed, 12 Sep 2018 22:32:47 +0000 (18:32 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 13 Oct 2018 04:50:47 +0000 (00:50 -0400)
kill the dead code, especially since ->break_ctl() will do the
right thing anyway.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/staging/dgnc/dgnc_tty.c

index 9accaa7..040af55 100644 (file)
@@ -2081,81 +2081,6 @@ static int dgnc_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
 
        switch (cmd) {
        /* Here are all the standard ioctl's that we MUST implement */
-
-       case TCSBRK:
-               /*
-                * TCSBRK is SVID version: non-zero arg --> no break
-                * this behaviour is exploited by tcdrain().
-                *
-                * According to POSIX.1 spec (7.2.2.1.2) breaks should be
-                * between 0.25 and 0.5 seconds so we'll ask for something
-                * in the middle: 0.375 seconds.
-                */
-               rc = tty_check_change(tty);
-               spin_unlock_irqrestore(&ch->ch_lock, flags);
-               if (rc)
-                       return rc;
-
-               rc = ch_bd_ops->drain(tty, 0);
-               if (rc)
-                       return -EINTR;
-
-               spin_lock_irqsave(&ch->ch_lock, flags);
-
-               if (((cmd == TCSBRK) && (!arg)) || (cmd == TCSBRKP))
-                       ch_bd_ops->send_break(ch, 250);
-
-               spin_unlock_irqrestore(&ch->ch_lock, flags);
-
-               return 0;
-
-       case TCSBRKP:
-               /*
-                * support for POSIX tcsendbreak()
-                * According to POSIX.1 spec (7.2.2.1.2) breaks should be
-                * between 0.25 and 0.5 seconds so we'll ask for something
-                * in the middle: 0.375 seconds.
-                */
-               rc = tty_check_change(tty);
-               spin_unlock_irqrestore(&ch->ch_lock, flags);
-               if (rc)
-                       return rc;
-
-               rc = ch_bd_ops->drain(tty, 0);
-               if (rc)
-                       return -EINTR;
-
-               spin_lock_irqsave(&ch->ch_lock, flags);
-
-               ch_bd_ops->send_break(ch, 250);
-
-               spin_unlock_irqrestore(&ch->ch_lock, flags);
-
-               return 0;
-
-       case TIOCSBRK:
-               rc = tty_check_change(tty);
-               spin_unlock_irqrestore(&ch->ch_lock, flags);
-               if (rc)
-                       return rc;
-
-               rc = ch_bd_ops->drain(tty, 0);
-               if (rc)
-                       return -EINTR;
-
-               spin_lock_irqsave(&ch->ch_lock, flags);
-
-               ch_bd_ops->send_break(ch, 250);
-
-               spin_unlock_irqrestore(&ch->ch_lock, flags);
-
-               return 0;
-
-       case TIOCCBRK:
-               /* Do Nothing */
-               spin_unlock_irqrestore(&ch->ch_lock, flags);
-               return 0;
-
        case TIOCGSOFTCAR:
 
                spin_unlock_irqrestore(&ch->ch_lock, flags);